Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1332703002: X87: [builtins] Unify the various versions of [[Call]] with a Call builtin. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Unify the various versions of [[Call]] with a Call builtin. port ccbb4ff00f1d8f32fd9227cd7aba1723791e5744 (r30629) original commit message: The new Call and CallFunction builtins supersede the current CallFunctionStub (and CallIC magic) and will be the single bottleneck for all calling, including the currently special Function.prototype.call and Function.prototype.apply builtins, which had handwritten (and not fully compliant) versions of CallFunctionStub, and also the CallIC(s), which where also slightly different. This also reduces the overhead for API function calls, which is still unnecessary high, but let's do that step-by-step. This also fixes a bunch of cases where the implicit ToObject for sloppy receivers was done in the wrong context (in the caller context instead of the callee context), which basically meant that we allowed cross context access to %ObjectPrototype%. BUG= Committed: https://crrev.com/20c9749b5ed9ecc4ce4631f14639007d36040284 Cr-Commit-Position: refs/heads/master@{#30668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -260 lines) Patch
M src/x87/assembler-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/builtins-x87.cc View 4 chunks +176 lines, -216 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 7 chunks +11 lines, -41 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 5 chunks +38 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-10 03:40:16 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-10 05:13:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332703002/1
5 years, 3 months ago (2015-09-10 05:14:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 05:41:38 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 05:42:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20c9749b5ed9ecc4ce4631f14639007d36040284
Cr-Commit-Position: refs/heads/master@{#30668}

Powered by Google App Engine
This is Rietveld 408576698