mozilla/security/nss/lib/freebl/gcm.c - Issue 13327005: PK11_DecryptWithSymKey and PK11_EncryptWithSymKey have been

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mozilla/security/nss/lib/freebl/gcm.c

Issue 13327005: PK11_DecryptWithSymKey and PK11_EncryptWithSymKey have been (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/nss/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mozilla/security/nss/lib/freebl/ecl/ecp_256_32.c ('k') | mozilla/security/nss/lib/pk11wrap/pk11obj.c » ('j') | mozilla/security/nss/lib/pk11wrap/pk11obj.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mozilla/security/nss/lib/freebl/gcm.c

===================================================================

--- mozilla/security/nss/lib/freebl/gcm.c (revision 190723)

+++ mozilla/security/nss/lib/freebl/gcm.c (working copy)

@@ -453,7 +453,9 @@

* we can hash it */

if (ghash->bufLen) {

unsigned int needed = PR_MIN(len, blocksize - ghash->bufLen);

- PORT_Memcpy(ghash->buffer+ghash->bufLen, buf, needed);

+ if (needed != 0) {

+ PORT_Memcpy(ghash->buffer+ghash->bufLen, buf, needed);

+ }

buf += needed;

len -= needed;

ghash->bufLen += needed;

@@ -814,7 +816,7 @@

/* get the authentication block */

if (inlen < tagBytes) {

- PORT_SetError(SEC_ERROR_INVALID_ARGS);

+ PORT_SetError(SEC_ERROR_INPUT_LEN);

return SECFailure;

}