Issue 13327002: Merge 190833 "Show user data dialog earlier on Windows."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13327002: Merge 190833 "Show user data dialog earlier on Windows." (Closed)

Created:
7 years, 8 months ago by hshi1

Modified:
7 years, 8 months ago

Reviewers:
hshi1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1453/src/

Visibility:
Public.

More Reviews

Description

Merge 190833 "Show user data dialog earlier on Windows." > Show user data dialog earlier on Windows. > > On Windows if the user data directory does not exist, we must show the user > data dir picker dialog prior to creating the local state to avoid a CHECK > failure. After obtaining the new dir we will restart chrome with the switch > --user-data-dir appended to the command line. > > BUG=196301 > TEST=CQ > > > Review URL: https://chromiumcodereview.appspot.com/12662033 TBR=hshi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191384

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -31 lines)			Patch
M	chrome/browser/browser_process.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	3 chunks	+2 lines, -36 lines	0 comments	Download
A +	chrome/browser/user_data_dir_extractor.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/user_data_dir_extractor.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/user_data_dir_extractor_win.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/user_data_dir_extractor_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/user_data_dir_extractor_win_browsertest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r191384.

Expand Messages | Collapse Messages