Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1332683002: Profiler code clean-up (Closed)

Created:
5 years, 3 months ago by yurys
Modified:
5 years, 3 months ago
Reviewers:
alph, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Profiler code clean-up BUG=None LOG=N Committed: https://crrev.com/6ed90e6dd0a7e9f3af53231b39e5f47cefac4edd Cr-Commit-Position: refs/heads/master@{#30702}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M src/profile-generator.h View 3 chunks +1 line, -4 lines 0 comments Download
M src/profile-generator.cc View 1 3 chunks +3 lines, -8 lines 0 comments Download
M src/profile-generator-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
yurys
5 years, 3 months ago (2015-09-10 15:14:10 UTC) #2
alph
lgtm
5 years, 3 months ago (2015-09-10 17:24:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332683002/1
5 years, 3 months ago (2015-09-10 17:49:02 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/4254) v8_linux_arm64_rel on ...
5 years, 3 months ago (2015-09-10 17:49:55 UTC) #7
Jakob Kummerow
LGTM. What's up with the try jobs?
5 years, 3 months ago (2015-09-11 09:17:46 UTC) #8
yurys
On 2015/09/11 09:17:46, Jakob wrote: > LGTM. > > What's up with the try jobs? ...
5 years, 3 months ago (2015-09-11 16:00:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332683002/40001
5 years, 3 months ago (2015-09-11 16:05:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-11 16:30:00 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 16:30:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ed90e6dd0a7e9f3af53231b39e5f47cefac4edd
Cr-Commit-Position: refs/heads/master@{#30702}

Powered by Google App Engine
This is Rietveld 408576698