Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1332663002: Reset webusb detector before browser client (Closed)

Created:
5 years, 3 months ago by juncai
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset webusb detector before browser client. This patch modified code to reset webusb detector before browser client, and added explicit keyword to WebUsbDetector constructor. BUG=492204 Committed: https://crrev.com/50087e6d65a05df6992a69301af7c273d670c788 Cr-Commit-Position: refs/heads/master@{#348042}

Patch Set 1 : reset webusb detector before browser client #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/webusb/webusb_detector.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
juncai
stevenjb@chromium.org and reillyg@chromium.org: Please review this patch.
5 years, 3 months ago (2015-09-09 22:05:35 UTC) #2
juncai
thestig@chromium.org: Please review changes in chrome/browser/chrome_browser_main.cc
5 years, 3 months ago (2015-09-09 22:06:15 UTC) #4
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-09 22:13:35 UTC) #5
stevenjb
lgtm
5 years, 3 months ago (2015-09-09 22:17:31 UTC) #6
Reilly Grant (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-09 23:45:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332663002/1
5 years, 3 months ago (2015-09-09 23:55:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 00:02:33 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/50087e6d65a05df6992a69301af7c273d670c788 Cr-Commit-Position: refs/heads/master@{#348042}
5 years, 3 months ago (2015-09-10 00:03:27 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:04:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50087e6d65a05df6992a69301af7c273d670c788
Cr-Commit-Position: refs/heads/master@{#348042}

Powered by Google App Engine
This is Rietveld 408576698