Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1332653005: Revert of Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities (Closed)

Created:
5 years, 3 months ago by mcasas
Modified:
5 years, 3 months ago
Reviewers:
emircan, aspoon
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities (patchset #3 id:60001 of https://codereview.chromium.org/1325303004/ ) Reason for revert: Temptative fix for https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester timeout on WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQuality/1 after 21330. Original issue's description: > Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities > > This format is already supported in the rest of the capture path. > Bluefish 444 is the capture card using it. > > BUG=508413 > TEST=Capture using a Bluefish 444 capture card > > Committed: https://crrev.com/6015405a94b144471eb0128779ad3c107192f445 > Cr-Commit-Position: refs/heads/master@{#347861} TBR=emircan@chromium.org,aspoon@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508413 Committed: https://crrev.com/b03c8d21c492c866080713eec568757e55660d10 Cr-Commit-Position: refs/heads/master@{#347992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -33 lines) Patch
M media/capture/video/win/sink_filter_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/sink_filter_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/capture/video/win/sink_input_pin_win.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/capture/video/win/sink_input_pin_win.cc View 7 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mcasas
Created Revert of Win Video Capture: add UYVY pixel format to Cr sink filter pin ...
5 years, 3 months ago (2015-09-09 20:24:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332653005/1
5 years, 3 months ago (2015-09-09 20:25:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 20:25:43 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b03c8d21c492c866080713eec568757e55660d10 Cr-Commit-Position: refs/heads/master@{#347992}
5 years, 3 months ago (2015-09-09 20:26:36 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:02:50 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b03c8d21c492c866080713eec568757e55660d10
Cr-Commit-Position: refs/heads/master@{#347992}

Powered by Google App Engine
This is Rietveld 408576698