Source/core/paint/BoxPainter.cpp - Issue 1332643002: Fix fixed-background offset issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/BoxPainter.cpp

Issue 1332643002: Fix fixed-background offset issue (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/paint/BoxPainter.cpp

diff --git a/Source/core/paint/BoxPainter.cpp b/Source/core/paint/BoxPainter.cpp

index 1796967054711ebd1d77c75ce4971f7baaae816a..382e0ed370f225dd8c9947a8a01f7acc854b2670 100644

--- a/Source/core/paint/BoxPainter.cpp

+++ b/Source/core/paint/BoxPainter.cpp

@@ -442,7 +442,7 @@ void BoxPainter::paintFillLayerExtended(LayoutBoxModelObject& obj, const PaintIn

BackgroundImageGeometry geometry;

if (bgImage)

- geometry.calculate(obj, paintInfo.paintContainer(), paintInfo.globalPaintFlags(), bgLayer, scrolledPaintRect, backgroundObject);

+ geometry.calculate(obj, paintInfo.paintContainer(), paintInfo.globalPaintFlags(), bgLayer, scrolledPaintRect, paintInfo.accumulatedScrollOffsetSincePaintContainer, backgroundObject);

bool shouldPaintBackgroundImage = bgImage && bgImage->canRender(obj, obj.style()->effectiveZoom());

// Paint the color first underneath all images, culled if background image occludes it.

« Source/core/paint/BackgroundImageGeometry.cpp ('K') | « Source/core/paint/BlockPainter.cpp ('k') | Source/core/paint/PaintInfo.h » ('j') | no next file with comments »