Add constructor to create SSLStatus from SSLInfo

chrome/browser/ssl/bad_clock_blocking_page.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/bad_clock_blocking_page.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/build_time.h"
 #include "base/callback_helpers.h"
@@ skipping 18 matching lines @@
 #include "chrome/grit/generated_resources.h"
 #include "components/google/core/browser/google_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cert_store.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/browser/signed_certificate_timestamp_store.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/renderer_preferences.h"
 #include "content/public/common/ssl_status.h"
 #include "grit/browser_resources.h"
 #include "grit/components_strings.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_util.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_ANDROID)
@@ skipping 220 matching lines @@
       base::TimeFormatShortDate(ssl_info_.cert->valid_expiry()));
   load_time_data->SetString("currentDate",
                             base::TimeFormatShortDate(time_triggered_));
   std::vector<std::string> encoded_chain;
   ssl_info_.cert->GetPEMEncodedChain(&encoded_chain);
   load_time_data->SetString(
       "pem", base::JoinString(encoded_chain, base::StringPiece()));
 }
 
 void BadClockBlockingPage::OverrideEntry(NavigationEntry* entry) {
+  int process_id = web_contents()->GetRenderProcessHost()->GetID();
   int cert_id = content::CertStore::GetInstance()->StoreCert(

[meacer, 2015/09/09 18:26:07]

How about consting process_id and cert_id too, since you have const int sct_id
below?

[estark, 2015/09/10 14:32:05]

Done.

-      ssl_info_.cert.get(), web_contents()->GetRenderProcessHost()->GetID());
+      ssl_info_.cert.get(), process_id);
   DCHECK(cert_id);
 
-  entry->GetSSL().security_style =
-      content::SECURITY_STYLE_AUTHENTICATION_BROKEN;
-  entry->GetSSL().cert_id = cert_id;
-  entry->GetSSL().cert_status = ssl_info_.cert_status;
-  entry->GetSSL().security_bits = ssl_info_.security_bits;
+  content::SignedCertificateTimestampStore* sct_store(
+      content::SignedCertificateTimestampStore::GetInstance());
+  content::SignedCertificateTimestampIDStatusList sct_ids;
+  for (const auto& sct_and_status : ssl_info_.signed_certificate_timestamps) {
+    const int sct_id(sct_store->Store(sct_and_status.sct.get(), process_id));
+    DCHECK(sct_id);
+    sct_ids.push_back(content::SignedCertificateTimestampIDAndStatus(
+        sct_id, sct_and_status.status));
+  }

[meacer, 2015/09/09 18:26:07]

Hah, I remember trying to do something like this in a very old CL which I never
got to land
(https://codereview.chromium.org/403933002/diff/180001/content/browser/loader/...)

Not that you need to change anything here.

+
+  entry->GetSSL() =
+      content::SSLStatus(content::SECURITY_STYLE_AUTHENTICATION_BROKEN, cert_id,
+                         sct_ids, ssl_info_);
 }
 
 // This handles the commands sent from the interstitial JavaScript.
 // DO NOT reorder or change this logic without also changing the JavaScript!
 void BadClockBlockingPage::CommandReceived(const std::string& command) {
   if (command == "\"pageLoadComplete\"") {
     // content::WaitForRenderFrameReady sends this message when the page
     // load completes. Ignore it.
     return;
   }
@@ skipping 47 matching lines @@
 
 void BadClockBlockingPage::NotifyDenyCertificate() {
   // It's possible that callback_ may not exist if the user clicks "Proceed"
   // followed by pressing the back button before the interstitial is hidden.
   // In that case the certificate will still be treated as allowed.
   if (callback_.is_null())
     return;
 
   base::ResetAndReturn(&callback_).Run(false);
 }