Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/Chromoting.java

Issue 133263003: Add 'default:' case to fix findbugs warning. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/android/java/src/org/chromium/chromoting/Chromoting.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/Chromoting.java b/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
index 8ae7928e8b9a76f59c5325d56f28f09ebe0280c0..977af35e1149201fdacc1a63902ea48094bc1210 100644
--- a/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
+++ b/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
@@ -412,6 +412,9 @@ public class Chromoting extends Activity implements JniInterface.ConnectionListe
dismissProgress = true;
finishActivity(0);
break;
+
+ default:
+ // Unreachable, but required by Google Java style and findbugs.
Sergey Ulanov 2014/01/11 08:55:47 Throw RuntimeException here?
Lambros 2014/01/13 17:38:32 Added an assertion, which seems the right thing to
}
if (dismissProgress && mProgressIndicator != null) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698