Issue 133263003: Add 'default:' case to fix findbugs warning.

Issue 133263003: Add 'default:' case to fix findbugs warning. (Closed)

Created:
6 years, 11 months ago by Lambros

Modified:
6 years, 11 months ago

Reviewers:
Sergey Ulanov, frankf

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add 'default:' case to fix findbugs warning. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244531

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	remoting/android/java/src/org/chromium/chromoting/Chromoting.java	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

LGTM when my comment is addressed. https://codereview.chromium.org/133263003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://codereview.chromium.org/133263003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode417 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:417: // Unreachable, but ...

6 years, 11 months ago (2014-01-11 08:55:46 UTC) #2

Lambros

https://codereview.chromium.org/133263003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://codereview.chromium.org/133263003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode417 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:417: // Unreachable, but required by Google Java style and ...

6 years, 11 months ago (2014-01-13 17:38:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/133263003/90001

6 years, 11 months ago (2014-01-13 18:02:06 UTC) #4

Message was sent while issue was closed.

Change committed as 244531

Expand Messages | Collapse Messages