Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1332563003: Vector ICs: No more patching for call ics. (Closed)

Created:
5 years, 3 months ago by mvstanton
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

On a call to Array(), we patched a call ic. This CL makes do with a single dispatcher which inlines the special handling for the Array() call case, loading the allocation site found in the vector and calling the array constructor stub appropriately. BUG= Committed: https://crrev.com/ba7b64139886ab7987406a92bf0e801b807c9fe4 Cr-Commit-Position: refs/heads/master@{#30649}

Patch Set 1 #

Patch Set 2 : Removed call ic patching. #

Patch Set 3 : Ports. #

Patch Set 4 : Fix x64 build break. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -344 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 5 chunks +17 lines, -34 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 5 chunks +19 lines, -36 lines 0 comments Download
M src/code-stubs.h View 1 5 chunks +1 line, -26 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 5 chunks +16 lines, -30 lines 0 comments Download
M src/ic/ic.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/ic/ic.cc View 1 3 chunks +12 lines, -97 lines 0 comments Download
M src/ic/ic-inl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 5 chunks +14 lines, -31 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 5 chunks +14 lines, -33 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 chunks +25 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mvstanton
Hi guys, Benedikt - could you review code-stubs*, as you were just in there. Jakob ...
5 years, 3 months ago (2015-09-08 12:07:25 UTC) #2
Jakob Kummerow
src/ic/* LGTM, love it!
5 years, 3 months ago (2015-09-08 14:08:28 UTC) #3
Benedikt Meurer
LGTM!
5 years, 3 months ago (2015-09-08 14:09:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332563003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332563003/60001
5 years, 3 months ago (2015-09-09 08:03:57 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-09 08:05:34 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 08:06:00 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ba7b64139886ab7987406a92bf0e801b807c9fe4
Cr-Commit-Position: refs/heads/master@{#30649}

Powered by Google App Engine
This is Rietveld 408576698