Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1332543002: Adding more testcases to :placeholder-shown class. (Closed)

Created:
5 years, 3 months ago by ramya.v
Modified:
5 years, 3 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding more testcases to :placeholder-shown class. As per the spec https://html.spec.whatwg.org/multipage/forms.html#input-type-attr-summary input types date, time, month, week, datetime-local, file, image, reset etc should ignore placeholder attribute and in-turn should not affect placeholder-shown state. Adding testcases for the same. BUG=451120 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201895

Patch Set 1 #

Patch Set 2 : Updated testcases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -8 lines) Patch
M LayoutTests/fast/css/placeholder-shown-basics.html View 1 2 chunks +52 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/placeholder-shown-basics-expected.html View 1 2 chunks +52 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ramya.v
PTAL! Thanks
5 years, 3 months ago (2015-09-08 03:53:16 UTC) #2
tkent
We should add the following types for complete coverage: search, date, month, week, time, datetime-local, ...
5 years, 3 months ago (2015-09-08 03:56:50 UTC) #3
ramya.v
On 2015/09/08 03:56:50, tkent wrote: > We should add the following types for complete coverage: ...
5 years, 3 months ago (2015-09-08 04:24:24 UTC) #4
tkent
lgtm
5 years, 3 months ago (2015-09-08 05:03:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332543002/20001
5 years, 3 months ago (2015-09-08 05:03:19 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 05:45:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201895

Powered by Google App Engine
This is Rietveld 408576698