Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 1332523002: testharnessreport: Hide elements in tests by removing them from the document tree, instead of visibi (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

testharnessreport: Hide elements in tests by removing them from the document tree, instead of visibility:hidden. This fixes the flakiness of web-platform-tests/webrtc/datachannel- emptystring.html. [1] made the test flaky because: - It added a chance to invoke onSendChannelOpen() - It prints some lines into <div id=msg>. - Text dump of visibility:hidden doesn't remove EOLs represented by <br>s. This CL resolves this issue by removing elements completely by body.textContent = ''. Setting display:none instead of visibility:hidden also works, but body.textContent = '' is much simpler. [1] https://src.chromium.org/viewvc/blink?revision=201628&view=revision BUG=528120 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201897

Patch Set 1 : #

Messages

Total messages: 7 (3 generated)
tkent
kojii@, would you review this please? This is a follow-up of https://codereview.chromium.org/1303313006/
5 years, 3 months ago (2015-09-08 05:02:02 UTC) #3
kojii
lgtm
5 years, 3 months ago (2015-09-08 05:49:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332523002/20001
5 years, 3 months ago (2015-09-08 06:27:19 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 06:31:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201897

Powered by Google App Engine
This is Rietveld 408576698