Descriptiontestharnessreport: Hide elements in tests by removing them from the document tree, instead of visibility:hidden.
This fixes the flakiness of web-platform-tests/webrtc/datachannel-
emptystring.html.
[1] made the test flaky because:
- It added a chance to invoke onSendChannelOpen()
- It prints some lines into <div id=msg>.
- Text dump of visibility:hidden doesn't remove EOLs represented by
<br>s.
This CL resolves this issue by removing elements completely by
body.textContent = ''. Setting display:none instead of visibility:hidden
also works, but body.textContent = '' is much simpler.
[1] https://src.chromium.org/viewvc/blink?revision=201628&view=revision
BUG=528120
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201897
Patch Set 1 : #Messages
Total messages: 7 (3 generated)
|