Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 13325002: Display prompt for caution only if it is an interactive shell (Closed)

Created:
7 years, 8 months ago by rmistry
Modified:
7 years, 8 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, skiabot_google.com
Visibility:
Public.

Description

Display prompt for caution only if it is an interactive shell. Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution. (SkipBuildbotRuns) Committed: https://code.google.com/p/skia/source/detail?r=8446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M PRESUBMIT.py View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
7 years, 8 months ago (2013-03-29 17:25:21 UTC) #1
rmistry
Committed patchset #1 manually as r8446 (presubmit successful).
7 years, 8 months ago (2013-03-29 17:26:04 UTC) #2
borenet
7 years, 8 months ago (2013-03-29 18:07:55 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698