Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1332493002: Revert "Implement proposed shadow tree cascade order." (Closed)

Created:
5 years, 3 months ago by rune
Modified:
5 years, 3 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Implement proposed shadow tree cascade order." This reverts commit bb5572c1de7405160a32b80c6224477b13eaac14. Conflicts: Source/core/css/resolver/StyleResolver.h TBR=kochi@chromium.org BUG=487125 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -273 lines) Patch
M LayoutTests/fast/css/content-distributed-nodes.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-distributed-nodes-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/css/deep-cascade-order.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/css/deep-cascade-order-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-redistribution.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html View 2 chunks +3 lines, -19 lines 0 comments Download
M LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/inner-scope-important-wins.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/dom/shadow/inner-scope-important-wins-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/outer-scope-lower-specificity-wins.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/dom/shadow/outer-scope-lower-specificity-wins-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/outer-scope-wins.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/outer-scope-wins-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html View 5 chunks +7 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/css/TreeBoundaryCrossingRules.h View 1 chunk +55 lines, -0 lines 0 comments Download
A Source/core/css/TreeBoundaryCrossingRules.cpp View 1 chunk +82 lines, -0 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 9 chunks +41 lines, -101 lines 0 comments Download
M Source/core/dom/DocumentOrderedList.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332493002/1
5 years, 3 months ago (2015-09-07 12:18:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201875
5 years, 3 months ago (2015-09-07 13:25:55 UTC) #3
kochi
5 years, 3 months ago (2015-09-07 13:27:29 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698