Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1332473003: Add new tool, git find-releases (Closed)

Created:
5 years, 3 months ago by scottmg
Modified:
5 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add new tool, git find-releases Finds the release(s) for a given change. Relies on using "git cherry-pick -x" per http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-drover.html so that the merge commit message contains the original commit. Example: d:\src\cr3\src>git show -s 53cc88da9a258bc4a34c4bff50025ee044c2e64d commit 53cc88da9a258bc4a34c4bff50025ee044c2e64d Author: grt <grt@chromium.org>; Date: Tue Jun 2 10:33:09 2015 -0700 Beacons for tracking default browser status. BUG=488247 R=gab@chromium.org,wfh@chromium.org Review URL: https://codereview.chromium.org/1146843003 Cr-Commit-Position: refs/heads/master@{#332423} "Now, where did that ship?" d:\src\cr3\src>git find-releases 53cc88da9a258bc4a34c4bff50025ee044c2e64d commit 53cc88da9a258bc4a34c4bff50025ee044c2e64d was: initially in 45.0.2421.0 merged to 43.0.2357.126 (as 8a5ccc0e0ad6b2237b2fcfffcb0ab24fe97bc77b) merged to 44.0.2403.39 (as d5d165943a88e51a64fd9e2fbcc781e4aaee270f) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296604

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : use regex in commit instead #

Patch Set 4 : lint #

Total comments: 3

Patch Set 5 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, --1 lines) Patch
A + git-find-releases View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A git_find_releases.py View 1 2 3 4 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Primiano Tucci (use gerrit)
See my internal comment, if you assume that cherry-picks are cherry-picked with -x, you can ...
5 years, 3 months ago (2015-09-05 12:37:36 UTC) #1
scottmg
Thanks Primiano. I couldn't get :/"X" to work as I wanted, but grepping works much ...
5 years, 3 months ago (2015-09-08 18:58:59 UTC) #3
Primiano Tucci (use gerrit)
Not an owner but LGTM. I eventually tried to figure out what is the coding ...
5 years, 3 months ago (2015-09-08 19:27:28 UTC) #4
scottmg
Thanks, done. Also checked for invalid commit being provided. +dpranke for owners review https://codereview.chromium.org/1332473003/diff/60001/git_find_releases.py File ...
5 years, 3 months ago (2015-09-08 21:21:07 UTC) #6
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-08 21:36:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332473003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332473003/80001
5 years, 3 months ago (2015-09-08 21:44:03 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296604
5 years, 3 months ago (2015-09-08 21:46:04 UTC) #11
eae
5 years, 3 months ago (2015-09-10 23:48:23 UTC) #12
Message was sent while issue was closed.
This is awesome, thank you!

Powered by Google App Engine
This is Rietveld 408576698