Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1332463002: Follow symlinks in test/mjsunit to allow linked test directories. (Closed)

Created:
5 years, 3 months ago by bradn
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Follow symlinks in test/mjsunit to allow linked test directories. Wasm mjsunit tests aren't being detected when symlinked into test/mjsunit/wasm. This causes symlinked directories in that directory to be included. BUG=None TEST=local R=dehrenberg@chromium.org LOG=N Committed: https://crrev.com/12889b4ad2698ed9c75271480742c3e0994c5895 Cr-Commit-Position: refs/heads/master@{#30600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bradn
5 years, 3 months ago (2015-09-04 22:50:16 UTC) #1
Dan Ehrenberg
lgtm
5 years, 3 months ago (2015-09-04 22:52:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332463002/1
5 years, 3 months ago (2015-09-04 22:52:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 23:15:57 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 23:16:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12889b4ad2698ed9c75271480742c3e0994c5895
Cr-Commit-Position: refs/heads/master@{#30600}

Powered by Google App Engine
This is Rietveld 408576698