components/version_ui.gypi - Issue 1332353003: Move resources for version_ui to //components/version_ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/version_ui.gypi

Issue 1332353003: Move resources for version_ui to //components/version_ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/version_ui.gypi

diff --git a/components/toolbar.gypi b/components/version_ui.gypi

similarity index 59%

copy from components/toolbar.gypi

copy to components/version_ui.gypi

index 77dc03909b459acaa06f46cf338bb82c19ab881f..ec92027994fab06f5017298ec63463160e8238fc 100644

--- a/components/toolbar.gypi

+++ b/components/version_ui.gypi

@@ -5,20 +5,16 @@

{

'targets': [

{

- # GN version: //components/toolbar

- 'target_name': 'toolbar',

+ # GN version: //components/version_ui

+ 'target_name': 'version_ui',

'type': 'static_library',

- 'dependencies': [

- '../base/base.gyp:base',

- '../url/url.gyp:url_lib',

- ],

'include_dirs': [

'..',

'sources': [

# Note: sources list duplicated in GN build.

- 'toolbar/toolbar_model.cc',

- 'toolbar/toolbar_model.h',

+ 'version_ui/version_ui_constants.cc',

+ 'version_ui/version_ui_constants.h',

« no previous file with comments | « components/version_info/version_info.cc ('k') | components/version_ui/BUILD.gn » ('j') | no next file with comments »