chrome/browser/ui/BUILD.gn - Issue 1332353003: Move resources for version_ui to //components/version_ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 1332353003: Move resources for version_ui to //components/version_ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/BUILD.gn

diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn

index b3ad7434c5a467f53221e768f0e912d52ba1450f..1b2039e2b8414bc9e9add39aa5b8fc66ec8f5776 100644

--- a/chrome/browser/ui/BUILD.gn

+++ b/chrome/browser/ui/BUILD.gn

@@ -57,6 +57,7 @@ source_set("ui") {

"//components/strings",

"//components/toolbar",

"//components/update_client",

+ "//components/version_ui",

"//content/public/common",

"//crypto",

"//skia",

@@ -345,9 +346,7 @@ source_set("ui") {

if (is_win) {

sources +=

rebase_path(gypi_values.chrome_browser_ui_win_sources, ".", "//chrome")

- sources -= [

- "views/frame/taskbar_decorator.cc",

- ]

+ sources -= [ "views/frame/taskbar_decorator.cc" ]

public_deps += [

"//ui/views",

"//ui/views/controls/webview",

« no previous file with comments | « chrome/browser/resources/about_version_android.css ('k') | chrome/browser/ui/DEPS » ('j') | components/version_ui/resources/about_version.html » ('J')