Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: components/version_info/version_info.cc

Issue 1332353003: Move resources for version_ui to //components/version_ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/version_info.grdp ('k') | components/version_ui.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/version_info/version_info.h" 5 #include "components/version_info/version_info.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "components/version_info/version_info_values.h" 8 #include "components/version_info/version_info_values.h"
9 #include "grit/components_strings.h" 9 #include "grit/components_strings.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 break; 78 break;
79 } 79 }
80 return std::string(); 80 return std::string();
81 } 81 }
82 82
83 std::string GetVersionStringWithModifier(const std::string& modifier) { 83 std::string GetVersionStringWithModifier(const std::string& modifier) {
84 std::string current_version; 84 std::string current_version;
85 current_version += GetVersionNumber(); 85 current_version += GetVersionNumber();
86 #if !defined(GOOGLE_CHROME_BUILD) 86 #if !defined(GOOGLE_CHROME_BUILD)
87 current_version += " ("; 87 current_version += " (";
88 current_version += l10n_util::GetStringUTF8(IDS_ABOUT_VERSION_UNOFFICIAL); 88 current_version += l10n_util::GetStringUTF8(IDS_VERSION_UI_UNOFFICIAL);
89 current_version += " "; 89 current_version += " ";
90 current_version += GetLastChange(); 90 current_version += GetLastChange();
91 current_version += " "; 91 current_version += " ";
92 current_version += GetOSType(); 92 current_version += GetOSType();
93 current_version += ")"; 93 current_version += ")";
94 #endif 94 #endif
95 if (!modifier.empty()) 95 if (!modifier.empty())
96 current_version += " " + modifier; 96 current_version += " " + modifier;
97 return current_version; 97 return current_version;
98 } 98 }
99 99
100 } // namespace version_info 100 } // namespace version_info
OLDNEW
« no previous file with comments | « components/version_info.grdp ('k') | components/version_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698