Move resources for version_ui to //components/version_ui

chrome/browser/ui/webui/version_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/version_handler.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/plugins/plugin_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/variations/active_field_trials.h"
+#include "components/version_ui/version_ui_constants.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/common/content_constants.h"
+#include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "url/gurl.h"
 
 namespace {
 
 // Retrieves the executable and profile paths on the FILE thread.
 void GetFilePaths(const base::FilePath& profile_path,
                   base::string16* exec_path_out,
                   base::string16* profile_path_out) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::FILE);
 
   base::FilePath executable_path = base::MakeAbsoluteFilePath(
       base::CommandLine::ForCurrentProcess()->GetProgram());
-  if (!executable_path.empty()) {
+  if (!executable_path.empty())
     *exec_path_out = executable_path.LossyDisplayName();
-  } else {
-    *exec_path_out =
-        l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_PATH_NOTFOUND);
-  }
+  else
+    *exec_path_out = l10n_util::GetStringUTF16(IDS_VERSION_UI_PATH_NOTFOUND);
 
   base::FilePath profile_path_copy(base::MakeAbsoluteFilePath(profile_path));
-  if (!profile_path.empty() && !profile_path_copy.empty()) {
+  if (!profile_path.empty() && !profile_path_copy.empty())
     *profile_path_out = profile_path.LossyDisplayName();
-  } else {
-    *profile_path_out =
-        l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_PATH_NOTFOUND);
-  }
+  else
+    *profile_path_out = l10n_util::GetStringUTF16(IDS_VERSION_UI_PATH_NOTFOUND);
 }
 
 }  // namespace
 
 VersionHandler::VersionHandler()
     : weak_ptr_factory_(this) {
 }
 
 VersionHandler::~VersionHandler() {
 }
 
 void VersionHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
-      "requestVersionInfo",
+      version_ui::kRequestVersionInfo,
       base::Bind(&VersionHandler::HandleRequestVersionInfo,
-      base::Unretained(this)));
+                 base::Unretained(this)));
 }
 
 void VersionHandler::HandleRequestVersionInfo(const base::ListValue* args) {
 #if defined(ENABLE_PLUGINS)
   // The Flash version information is needed in the response, so make sure
   // the plugins are loaded.
   content::PluginService::GetInstance()->GetPlugins(
       base::Bind(&VersionHandler::OnGotPlugins,
           weak_ptr_factory_.GetWeakPtr()));
 #endif
@@ skipping 32 matching lines @@
   variations::GetFieldTrialActiveGroupIdsAsStrings(&variations);
 #endif
 
   base::ListValue variations_list;
   for (std::vector<std::string>::const_iterator it = variations.begin();
       it != variations.end(); ++it) {
     variations_list.Append(new base::StringValue(*it));
   }
 
   // In release mode, this will return an empty list to clear the section.
-  web_ui()->CallJavascriptFunction("returnVariationInfo", variations_list);
+  web_ui()->CallJavascriptFunction(version_ui::kReturnVariationInfo,
+                                   variations_list);
 }
 
 void VersionHandler::OnGotFilePaths(base::string16* executable_path_data,
                                     base::string16* profile_path_data) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   base::StringValue exec_path(*executable_path_data);
   base::StringValue profile_path(*profile_path_data);
-  web_ui()->CallJavascriptFunction("returnFilePaths", exec_path, profile_path);
+  web_ui()->CallJavascriptFunction(version_ui::kReturnFilePaths, exec_path,
+                                   profile_path);
 }
 
 #if defined(ENABLE_PLUGINS)
 void VersionHandler::OnGotPlugins(
     const std::vector<content::WebPluginInfo>& plugins) {
   // Obtain the version of the first enabled Flash plugin.
   std::vector<content::WebPluginInfo> info_array;
   content::PluginService::GetInstance()->GetPluginInfoArray(
       GURL(), content::kFlashPluginSwfMimeType, false, &info_array, NULL);
   base::string16 flash_version =
       l10n_util::GetStringUTF16(IDS_PLUGINS_DISABLED_PLUGIN);
   PluginPrefs* plugin_prefs =
       PluginPrefs::GetForProfile(Profile::FromWebUI(web_ui())).get();
   if (plugin_prefs) {
     for (size_t i = 0; i < info_array.size(); ++i) {
       if (plugin_prefs->IsPluginEnabled(info_array[i])) {
         flash_version = info_array[i].version;
         break;
       }
     }
   }
 
   base::StringValue arg(flash_version);
-  web_ui()->CallJavascriptFunction("returnFlashVersion", arg);
+  web_ui()->CallJavascriptFunction(version_ui::kReturnFlashVersion, arg);
 }
 #endif  // defined(ENABLE_PLUGINS)