components/resources/version_ui_resources.grdp - Issue 1332353003: Move resources for version_ui to //components/version_ui

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/resources/version_ui_resources.grdp

Issue 1332353003: Move resources for version_ui to //components/version_ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <grit-part>

	3 <include name="IDR_VERSION_UI_CSS" file="../version_ui/resources/about_version .css" type="BINDATA" />
	Dan Beam 2015/10/15 04:02:35 this is kind of weird... why wouldn't a .grd that this is kind of weird... why wouldn't a .grd that has .grdp's in various sub directory live in the common ancestor? i.e. components/ can_access_version_ui_and_resources.grd <part file=version_ui/some.grdp> <part file=resources/some.grdp> version_ui/ some.grdp resources/ some.grdp or whatever droger 2015/10/15 15:21:57 I agree, but all components resources are architec Show quoted text On 2015/10/15 04:02:35, Dan Beam wrote: > this is kind of weird... why wouldn't a .grd that has .grdp's in various sub > directory live in the common ancestor? > > i.e. > > components/ > > can_access_version_ui_and_resources.grd > <part file=version_ui/some.grdp> > <part file=resources/some.grdp> > > version_ui/ > some.grdp > > resources/ > some.grdp > > or whatever I agree, but all components resources are architectured like this. In other words, this file is consistent with the ~15 other resource files in this directory. I think changing this is out of scope of this CL.
	4 <include name="IDR_VERSION_UI_HTML" file="../version_ui/resources/about_versio n.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />

	5 <include name="IDR_VERSION_UI_JS" file="../version_ui/resources/about_version. js" type="BINDATA" />

	6 </grit-part>

OLD	NEW

« chrome/browser/ui/webui/version_handler.cc ('K') | « components/resources/components_resources.grd ('k') | components/version_info.grdp » ('j') | components/version_ui_strings.grdp » ('J')