Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: ui/events/ozone/event_converter_ozone.h

Issue 133233008: evdev: Move EventConverterOzone ownership from EventFactoryOzone to subclass (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dropped EventConverterEvdev Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/ozone/evdev/touch_event_converter.cc ('k') | ui/events/ozone/event_converter_ozone.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/ozone/event_converter_ozone.h
diff --git a/ui/events/ozone/event_converter_ozone.h b/ui/events/ozone/event_converter_ozone.h
index 90826c26580d341ab94c7116edea219315ea51de..ab8144424098d0b4742b140e25c1e03aecafe3e4 100644
--- a/ui/events/ozone/event_converter_ozone.h
+++ b/ui/events/ozone/event_converter_ozone.h
@@ -6,21 +6,16 @@
#define UI_EVENTS_OZONE_EVENT_CONVERTER_OZONE_H_
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_pump_libevent.h"
#include "ui/events/events_export.h"
namespace ui {
class Event;
-// In ozone, Chrome reads events from file descriptors created from Linux device
-// drivers. The |MessagePumpLibevent::Watcher| parent class provides the
-// functionality to watch a file descriptor for the arrival of new data and
-// notify its subclasses. Device-specific event converters turn bytes read from
-// the file descriptor into |ui::Event| instances. This class provides the
-// functionality needed in common across all converters: dispatching the
-// |ui::Event| to aura.
-class EVENTS_EXPORT EventConverterOzone
- : public base::MessagePumpLibevent::Watcher {
+// Ozone implementations can generate input events in whatever way is
+// appropriate for the platform.
+// This class provides the functionality needed in common across all
+// converters: dispatching the |ui::Event| to aura.
+class EVENTS_EXPORT EventConverterOzone {
public:
EventConverterOzone();
virtual ~EventConverterOzone();
@@ -29,7 +24,7 @@ class EVENTS_EXPORT EventConverterOzone
// Subclasses should use this method to post a task that will dispatch
// |event| from the UI message loop. This method takes ownership of
// |event|. |event| will be deleted at the end of the posted task.
- virtual void DispatchEvent(scoped_ptr<ui::Event> event);
+ static void DispatchEvent(scoped_ptr<ui::Event> event);
spang 2014/01/28 22:01:32 This is looking pretty lonely. All that's left her
rjkroege 2014/01/28 23:27:55 sgtm. Added to EventFactory perhaps?
private:
DISALLOW_COPY_AND_ASSIGN(EventConverterOzone);
« no previous file with comments | « ui/events/ozone/evdev/touch_event_converter.cc ('k') | ui/events/ozone/event_converter_ozone.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698