evdev: Move EventConverterOzone ownership from EventFactoryOzone to subclass

evdev: Move EventConverterOzone ownership from EventFactoryOzone to subclass

That way, event converters can be organized in whichever way is most useful
for the platform. For evdev, organize by device path. This will let us find
out which which devices have already been opened and is needed for hotplug.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247764

[spang, 2014-01-24 17:56:38]

on top of https://codereview.chromium.org/144233006/

[spang, 2014-01-28 21:54:43]

On 2014/01/24 17:56:38, spang wrote:
> on top of https://codereview.chromium.org/144233006/

this is now standalone.

[spang, 2014-01-28 22:01:31]

https://codereview.chromium.org/133233008/diff/40001/ui/events/ozone/event_co...
File ui/events/ozone/event_converter_ozone.h (right):

https://codereview.chromium.org/133233008/diff/40001/ui/events/ozone/event_co...
ui/events/ozone/event_converter_ozone.h:27: static void
DispatchEvent(scoped_ptr<ui::Event> event);
This is looking pretty lonely. All that's left here is DispatchEvent, which is
static. Furthermore, we never reference these objects in common code.

I think this class can go..

[rjkroege, 2014-01-28 23:27:54]

lgtm

https://codereview.chromium.org/133233008/diff/40001/ui/events/ozone/event_co...
File ui/events/ozone/event_converter_ozone.h (right):

https://codereview.chromium.org/133233008/diff/40001/ui/events/ozone/event_co...
ui/events/ozone/event_converter_ozone.h:27: static void
DispatchEvent(scoped_ptr<ui::Event> event);
On 2014/01/28 22:01:32, spang wrote:
> This is looking pretty lonely. All that's left here is DispatchEvent, which is
> static. Furthermore, we never reference these objects in common code.
> 
> I think this class can go..

sgtm. Added to EventFactory perhaps?

[spang, 2014-01-29 00:46:32]

On 2014/01/28 23:27:54, rjkroege wrote:
> lgtm
> 
>
https://codereview.chromium.org/133233008/diff/40001/ui/events/ozone/event_co...
> File ui/events/ozone/event_converter_ozone.h (right):
> 
>
https://codereview.chromium.org/133233008/diff/40001/ui/events/ozone/event_co...
> ui/events/ozone/event_converter_ozone.h:27: static void
> DispatchEvent(scoped_ptr<ui::Event> event);
> On 2014/01/28 22:01:32, spang wrote:
> > This is looking pretty lonely. All that's left here is DispatchEvent, which
is
> > static. Furthermore, we never reference these objects in common code.
> > 
> > I think this class can go..
> 
> sgtm. Added to EventFactory perhaps?

Will followup. This has implications for EventFactoryEvdev, and I am apparently
relying DispatchEvent being virtual in the key_event_converter_unittest.

[commit-bot: I haz the power, 2014-01-29 12:34:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/133233008/60001

[commit-bot: I haz the power, 2014-01-29 13:10:35]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 13:11:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/133233008/60001

[commit-bot: I haz the power, 2014-01-29 14:52:34]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 16:15:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/133233008/60001

[commit-bot: I haz the power, 2014-01-29 18:06:50]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 18:11:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/133233008/60001

[commit-bot: I haz the power, 2014-01-29 22:50:04]

Change committed as 247764