Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 133233002: Recover gallery after crash in Files app. (Closed)

Created:
6 years, 11 months ago by mtomasz
Modified:
6 years, 11 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Recover gallery after crash in Files app. Recent regression broke restoring the gallery view after crash. This patch fixes this issue. Along the way restoring archives has been removed, since the implementation is not reliable. TEST=Tested manually. BUG=333136 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 2 chunks +10 lines, -18 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/photo/gallery.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@hirono: PTAL. Thanks!
6 years, 11 months ago (2014-01-10 04:31:14 UTC) #1
hirono
lgtm!
6 years, 11 months ago (2014-01-10 04:38:24 UTC) #2
mtomasz
On 2014/01/10 04:38:24, hirono wrote: > lgtm! Thanks!
6 years, 11 months ago (2014-01-10 04:42:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/133233002/1
6 years, 11 months ago (2014-01-10 04:43:00 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244682
6 years, 11 months ago (2014-01-10 09:50:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/133233002/1
6 years, 11 months ago (2014-01-10 10:02:16 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 11:47:12 UTC) #7
Message was sent while issue was closed.
Change committed as 244151

Powered by Google App Engine
This is Rietveld 408576698