permissions: switch from explicitly passing queue controller to callbacks

chrome/browser/permissions/permission_infobar_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_INFOBAR_DELEGATE_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_INFOBAR_DELEGATE_H_
 
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/permissions/permission_request_id.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "content/public/browser/web_contents.h"
 
 class NavigationDetails;
-class PermissionQueueController;
 
 // Base class for permission infobars, it implements the default behavior
 // so that the accept/deny buttons grant/deny the relevant permission.
 // A basic implementor only needs to implement the methods that
 // provide an icon and a message text to the infobar.
 class PermissionInfobarDelegate : public ConfirmInfoBarDelegate {
 
  public:
   ContentSettingsType content_setting() const { return type_; }
 
  protected:
-  PermissionInfobarDelegate(PermissionQueueController* controller,
-                            const PermissionRequestID& id,
+  PermissionInfobarDelegate(const PermissionRequestID& id,

[mlamouri (slow - plz ping), 2015/09/15 12:55:59]

Do you still need this? |id| doesn't seem to be used anymore.

[Lalit Maganti, 2015/09/15 14:19:25]

Done.

                             const GURL& requesting_origin,
-                            ContentSettingsType type);
+                            ContentSettingsType type,
+                            const base::Callback<void(bool, bool)>& callback);

[mlamouri (slow - plz ping), 2015/09/15 12:55:59]

nit:  could you name the callback so readers know what is is for?
using PermissionSetCallback = base::Callback<void(bool, bool)>;

And have all the classes inheriting from PermissionInfobarDelegate uses this
name.

[Lalit Maganti, 2015/09/15 14:19:24]

Done.

   ~PermissionInfobarDelegate() override;
 
  private:
   // ConfirmInfoBarDelegate:
   Type GetInfoBarType() const override;
   void InfoBarDismissed() override;
   PermissionInfobarDelegate* AsPermissionInfobarDelegate() override;
   base::string16 GetButtonLabel(InfoBarButton button) const override;
   bool Accept() override;
   bool Cancel() override;
 
   void SetPermission(bool update_content_setting, bool allowed);
 
-  PermissionQueueController* controller_; // not owned by us
   const PermissionRequestID id_;
   GURL requesting_origin_;
   bool action_taken_;
   ContentSettingsType type_;
+  const base::Callback<void(bool, bool)> callback_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionInfobarDelegate);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_INFOBAR_DELEGATE_H_