permissions: switch from explicitly passing queue controller to callbacks

chrome/browser/media/protected_media_identifier_infobar_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/protected_media_identifier_infobar_delegate.h"
 
 #include "chrome/browser/infobars/infobar_service.h"
-#include "chrome/browser/permissions/permission_queue_controller.h"
 #include "chrome/browser/permissions/permission_request_id.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/infobars/core/infobar.h"
 #include "components/url_formatter/url_formatter.h"
 #include "grit/components_strings.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 // static
 infobars::InfoBar* ProtectedMediaIdentifierInfoBarDelegate::Create(
     InfoBarService* infobar_service,
-    PermissionQueueController* controller,
     const PermissionRequestID& id,
     const GURL& requesting_frame,
-    const std::string& display_languages) {
+    const std::string& display_languages,
+    const base::Callback<void(bool, bool)>& callback) {
   return infobar_service->AddInfoBar(
       infobar_service->CreateConfirmInfoBar(scoped_ptr<ConfirmInfoBarDelegate>(
           new ProtectedMediaIdentifierInfoBarDelegate(
-              controller, id, requesting_frame, display_languages))));
+              id, requesting_frame, display_languages, callback))));
 }
 
-
 ProtectedMediaIdentifierInfoBarDelegate::
     ProtectedMediaIdentifierInfoBarDelegate(
-    PermissionQueueController* controller,
     const PermissionRequestID& id,
     const GURL& requesting_frame,
-    const std::string& display_languages)
+    const std::string& display_languages,
+    const base::Callback<void(bool, bool)>& callback)
     : ConfirmInfoBarDelegate(),
-      controller_(controller),
       id_(id),
       requesting_frame_(requesting_frame),
-      display_languages_(display_languages) {
+      display_languages_(display_languages),
+      callback_(callback) {
 }
 
 ProtectedMediaIdentifierInfoBarDelegate::
     ~ProtectedMediaIdentifierInfoBarDelegate() {
 }
 
 bool ProtectedMediaIdentifierInfoBarDelegate::Accept() {
   SetPermission(true, true);
   return true;
 }
 
 void ProtectedMediaIdentifierInfoBarDelegate::SetPermission(

[mlamouri (slow - plz ping), 2015/09/15 12:55:59]

Why is that needed? Could it directly inherits from PermissionInfobarDelegate?

[Lalit Maganti, 2015/09/15 13:16:53]

IDK why but right now it does not inherit from PermissionInfobarDelegate. I
could make it inherit but I thought it would just pollute this change.

[Lalit Maganti, 2015/09/15 14:19:24]

Done.

     bool update_content_setting,
     bool allowed) {
-  content::WebContents* web_contents =
-      InfoBarService::WebContentsFromInfoBar(infobar());
-  controller_->OnPermissionSet(id_, requesting_frame_,
-                               web_contents->GetLastCommittedURL().GetOrigin(),
-                               update_content_setting, allowed);
+  callback_.Run(update_content_setting, allowed);
 }
 
 infobars::InfoBarDelegate::Type
 ProtectedMediaIdentifierInfoBarDelegate::GetInfoBarType() const {
   return PAGE_ACTION_TYPE;
 }
 
 int ProtectedMediaIdentifierInfoBarDelegate::GetIconId() const {
   return IDR_INFOBAR_PROTECTED_MEDIA_IDENTIFIER;
 }
@@ skipping 28 matching lines @@
 bool ProtectedMediaIdentifierInfoBarDelegate::LinkClicked(
     WindowOpenDisposition disposition) {
   InfoBarService::WebContentsFromInfoBar(infobar())
       ->OpenURL(content::OpenURLParams(
           GURL(chrome::kEnhancedPlaybackNotificationLearnMoreURL),
           content::Referrer(),
           (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
           ui::PAGE_TRANSITION_LINK, false));
   return false; // Do not dismiss the info bar.
 }