Remove dependency of PrefSyncableService on PrefsTabHelper.

chrome/browser/prefs/pref_service_syncable_util.h

Index: chrome/browser/prefs/pref_service_syncable_util.h
diff --git a/chrome/browser/prefs/pref_service_syncable_util.h b/chrome/browser/prefs/pref_service_syncable_util.h
index 71dd077448865e37841b364d893b9971483607f5..1c9184acd9e70731afdf70fcc200f8af721a9eaf 100644
--- a/chrome/browser/prefs/pref_service_syncable_util.h
+++ b/chrome/browser/prefs/pref_service_syncable_util.h
@@ -6,6 +6,7 @@
 #define CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_UTIL_H_
 
 class PrefServiceSyncable;
+class PrefStore;
 class Profile;
 
 // PrefServiceSyncable is a PrefService with added integration for
@@ -20,4 +21,12 @@ class Profile;
 PrefServiceSyncable* PrefServiceSyncableFromProfile(Profile* profile);
 PrefServiceSyncable* PrefServiceSyncableIncognitoFromProfile(Profile* profile);
 
+// Creates an incognito copy of the pref service that shares most pref stores

[gab, 2015/09/14 16:20:10]

s/the pref service/|pref_service|/

[gab, 2015/09/14 16:20:10]

s/shares most pref stores/shares most prefs/

[sdefresne, 2015/09/14 17:28:29]

Done and done.

+// but uses a fresh non-persistent overlay for the user pref store and an
+// individual extension pref store (to cache the effective extension prefs for
+// incognito windows).
+PrefServiceSyncable* CreateIncognitoPrefServiceSyncable(
+    PrefServiceSyncable* pref_service,
+    PrefStore* incognito_extension_prefs);

[gab, 2015/09/14 16:20:10]

I know this was there prior to your change, but could we
s/incognito_extensions_prefs/incognito_extension_pref_store/ here and elsewhere?

It took me some time to realize what this was otherwise.

[sdefresne, 2015/09/14 17:28:29]

Done.

+
 #endif  // CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_UTIL_H_