test/cctest/test-assembler-arm64.cc - Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-assembler-arm64.cc

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix arm64 PatchingAssembler that initialized its isolate with NULL :) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-assembler-arm64.cc

diff --git a/test/cctest/test-assembler-arm64.cc b/test/cctest/test-assembler-arm64.cc

index 3c2f840058aadb6cc7123ee5eb7e8dfd3d84a8d4..9b511851dd2f88186420bfa2ae14df6fa279b0aa 100644

--- a/test/cctest/test-assembler-arm64.cc

+++ b/test/cctest/test-assembler-arm64.cc

@@ -191,12 +191,12 @@ static void InitializeVM() {

RESET(); \

START_AFTER_RESET();

-#define RUN() \

- CpuFeatures::FlushICache(buf, masm.SizeOfGeneratedCode()); \

- { \

- void (*test_function)(void); \

- memcpy(&test_function, &buf, sizeof(buf)); \

- test_function(); \

+#define RUN() \

+ Assembler::FlushICache(isolate, buf, masm.SizeOfGeneratedCode()); \

+ { \

+ void (*test_function)(void); \

+ memcpy(&test_function, &buf, sizeof(buf)); \

+ test_function(); \

}

#define END() \

« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | test/cctest/test-code-stubs-arm.cc » ('j') | no next file with comments »