src/arm64/codegen-arm64.cc - Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/codegen-arm64.cc

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments + made AssemblerBase methods public ;( Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/codegen-arm64.cc

diff --git a/src/arm64/codegen-arm64.cc b/src/arm64/codegen-arm64.cc

index 6efe84c681cab2e71a5d969f20a941cfe7a449ad..8e927bfd9051ca63961b6533b0ce516829b80237 100644

--- a/src/arm64/codegen-arm64.cc

+++ b/src/arm64/codegen-arm64.cc

@@ -64,7 +64,7 @@ UnaryMathFunction CreateExpFunction() {

masm.GetCode(&desc);

DCHECK(!RelocInfo::RequiresRelocation(desc));

- CpuFeatures::FlushICache(buffer, actual_size);

+ Assembler::FlushICacheWithoutIsolate(buffer, actual_size);

base::OS::ProtectCode(buffer, actual_size);

#if !defined(USE_SIMULATOR)

« src/arm/assembler-arm.h ('K') | « src/arm64/assembler-arm64-inl.h ('k') | src/arm64/cpu-arm64.cc » ('j') | no next file with comments »