src/arm/code-stubs-arm.h - Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.h

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments + made AssemblerBase methods public ;( Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/code-stubs-arm.h

diff --git a/src/arm/code-stubs-arm.h b/src/arm/code-stubs-arm.h

index b2b2c08cd837acfff263a92bbcf4dd230714919e..e572fd9a1b0ce289f7bf03dbf4bd5fedc0885597 100644

--- a/src/arm/code-stubs-arm.h

+++ b/src/arm/code-stubs-arm.h

@@ -129,8 +129,8 @@ class RecordWriteStub: public PlatformCodeStub {

break;

}

DCHECK(GetMode(stub) == mode);

- CpuFeatures::FlushICache(stub->instruction_start(),

- 2 * Assembler::kInstrSize);

+ Assembler::FlushICache(stub->GetIsolate(), stub->instruction_start(),

+ 2 * Assembler::kInstrSize);

}

DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR();

« src/arm/assembler-arm.h ('K') | « src/arm/assembler-arm-inl.h ('k') | src/arm/codegen-arm.cc » ('j') | no next file with comments »