Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: src/arm64/assembler-arm64.h

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Try to fix cpu-arm once more Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/arm64/assembler-arm64.h
diff --git a/src/arm64/assembler-arm64.h b/src/arm64/assembler-arm64.h
index a7e5a06640212544632cd2c195d2f429311e75f3..7c9c544f763657ecbb5ae2507dd8101b193960b2 100644
--- a/src/arm64/assembler-arm64.h
+++ b/src/arm64/assembler-arm64.h
@@ -810,6 +810,9 @@ class ConstPool {
class Assembler : public AssemblerBase {
public:
+ using AssemblerBase::FlushICache;
+ using AssemblerBase::FlushICacheWithoutIsolate;
+
// Create an assembler. Instructions and relocation information are emitted
// into a buffer, with the instructions starting from the beginning and the
// relocation information starting from the end of the buffer. See CodeDesc
@@ -2279,7 +2282,7 @@ class PatchingAssembler : public Assembler {
DCHECK(IsConstPoolEmpty());
// Flush the Instruction cache.
size_t length = buffer_size_ - kGap;
- CpuFeatures::FlushICache(buffer_, length);
+ Assembler::FlushICacheWithoutIsolate(buffer_, length);
}
// See definition of PatchAdrFar() for details.

Powered by Google App Engine
This is Rietveld 408576698