Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: test/cctest/test-code-stubs-arm.cc

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm64 PatchingAssembler that initialized its isolate with NULL :) Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-assembler-arm64.cc ('k') | test/cctest/test-code-stubs-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Rrdistribution and use in source and binary forms, with or without 2 // Rrdistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Rrdistributions of source code must retain the above copyright 6 // * Rrdistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Rrdistributions in binary form must reproduce the above 8 // * Rrdistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 __ mov(r0, destination_reg); 119 __ mov(r0, destination_reg);
120 120
121 // Restore callee save registers. 121 // Restore callee save registers.
122 __ Pop(lr); 122 __ Pop(lr);
123 __ Pop(r7, r6, r5, r4); 123 __ Pop(r7, r6, r5, r4);
124 124
125 __ Ret(0); 125 __ Ret(0);
126 126
127 CodeDesc desc; 127 CodeDesc desc;
128 masm.GetCode(&desc); 128 masm.GetCode(&desc);
129 CpuFeatures::FlushICache(buffer, actual_size); 129 Assembler::FlushICache(isolate, buffer, actual_size);
130 return (reinterpret_cast<ConvertDToIFunc>( 130 return (reinterpret_cast<ConvertDToIFunc>(
131 reinterpret_cast<intptr_t>(buffer))); 131 reinterpret_cast<intptr_t>(buffer)));
132 } 132 }
133 133
134 #undef __ 134 #undef __
135 135
136 136
137 static Isolate* GetIsolateFrom(LocalContext* context) { 137 static Isolate* GetIsolateFrom(LocalContext* context) {
138 return reinterpret_cast<Isolate*>((*context)->GetIsolate()); 138 return reinterpret_cast<Isolate*>((*context)->GetIsolate());
139 } 139 }
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 false)); 175 false));
176 RunAllTruncationTests( 176 RunAllTruncationTests(
177 RunGeneratedCodeCallWrapper, 177 RunGeneratedCodeCallWrapper,
178 MakeConvertDToIFuncTrampoline(isolate, 178 MakeConvertDToIFuncTrampoline(isolate,
179 source_registers[s], 179 source_registers[s],
180 dest_registers[d], 180 dest_registers[d],
181 true)); 181 true));
182 } 182 }
183 } 183 }
184 } 184 }
OLDNEW
« no previous file with comments | « test/cctest/test-assembler-arm64.cc ('k') | test/cctest/test-code-stubs-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698