Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Side by Side Diff: src/ia32/code-stubs-ia32.h

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm64 PatchingAssembler that initialized its isolate with NULL :) Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IA32_CODE_STUBS_IA32_H_ 5 #ifndef V8_IA32_CODE_STUBS_IA32_H_
6 #define V8_IA32_CODE_STUBS_IA32_H_ 6 #define V8_IA32_CODE_STUBS_IA32_H_
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 10
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 DCHECK(GetMode(stub) == STORE_BUFFER_ONLY); 181 DCHECK(GetMode(stub) == STORE_BUFFER_ONLY);
182 stub->instruction_start()[0] = kTwoByteJumpInstruction; 182 stub->instruction_start()[0] = kTwoByteJumpInstruction;
183 break; 183 break;
184 case INCREMENTAL_COMPACTION: 184 case INCREMENTAL_COMPACTION:
185 DCHECK(GetMode(stub) == STORE_BUFFER_ONLY); 185 DCHECK(GetMode(stub) == STORE_BUFFER_ONLY);
186 stub->instruction_start()[0] = kTwoByteNopInstruction; 186 stub->instruction_start()[0] = kTwoByteNopInstruction;
187 stub->instruction_start()[2] = kFiveByteJumpInstruction; 187 stub->instruction_start()[2] = kFiveByteJumpInstruction;
188 break; 188 break;
189 } 189 }
190 DCHECK(GetMode(stub) == mode); 190 DCHECK(GetMode(stub) == mode);
191 CpuFeatures::FlushICache(stub->instruction_start(), 7); 191 Assembler::FlushICache(stub->GetIsolate(), stub->instruction_start(), 7);
192 } 192 }
193 193
194 DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR(); 194 DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR();
195 195
196 private: 196 private:
197 // This is a helper class for freeing up 3 scratch registers, where the third 197 // This is a helper class for freeing up 3 scratch registers, where the third
198 // is always ecx (needed for shift operations). The input is two registers 198 // is always ecx (needed for shift operations). The input is two registers
199 // that must be preserved and one scratch register provided by the caller. 199 // that must be preserved and one scratch register provided by the caller.
200 class RegisterAllocation { 200 class RegisterAllocation {
201 public: 201 public:
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 381
382 RegisterAllocation regs_; 382 RegisterAllocation regs_;
383 383
384 DISALLOW_COPY_AND_ASSIGN(RecordWriteStub); 384 DISALLOW_COPY_AND_ASSIGN(RecordWriteStub);
385 }; 385 };
386 386
387 387
388 } } // namespace v8::internal 388 } } // namespace v8::internal
389 389
390 #endif // V8_IA32_CODE_STUBS_IA32_H_ 390 #endif // V8_IA32_CODE_STUBS_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698