Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: src/arm/assembler-arm.h

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments + made AssemblerBase methods public ;( Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/assembler-arm-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 652
653 653
654 struct VmovIndex { 654 struct VmovIndex {
655 unsigned char index; 655 unsigned char index;
656 }; 656 };
657 const VmovIndex VmovIndexLo = { 0 }; 657 const VmovIndex VmovIndexLo = { 0 };
658 const VmovIndex VmovIndexHi = { 1 }; 658 const VmovIndex VmovIndexHi = { 1 };
659 659
660 class Assembler : public AssemblerBase { 660 class Assembler : public AssemblerBase {
661 public: 661 public:
662 using AssemblerBase::FlushICache;
663 using AssemblerBase::FlushICacheWithoutIsolate;
Michael Starzinger 2015/09/11 11:58:40 Now that the methods on AssemblerBase are public,
Michael Lippautz 2015/09/11 12:10:24 Done.
664
662 // Create an assembler. Instructions and relocation information are emitted 665 // Create an assembler. Instructions and relocation information are emitted
663 // into a buffer, with the instructions starting from the beginning and the 666 // into a buffer, with the instructions starting from the beginning and the
664 // relocation information starting from the end of the buffer. See CodeDesc 667 // relocation information starting from the end of the buffer. See CodeDesc
665 // for a detailed comment on the layout (globals.h). 668 // for a detailed comment on the layout (globals.h).
666 // 669 //
667 // If the provided buffer is NULL, the assembler allocates and grows its own 670 // If the provided buffer is NULL, the assembler allocates and grows its own
668 // buffer, and buffer_size determines the initial buffer size. The buffer is 671 // buffer, and buffer_size determines the initial buffer size. The buffer is
669 // owned by the assembler and deallocated upon destruction of the assembler. 672 // owned by the assembler and deallocated upon destruction of the assembler.
670 // 673 //
671 // If the provided buffer is not NULL, the assembler uses the provided buffer 674 // If the provided buffer is not NULL, the assembler uses the provided buffer
(...skipping 983 matching lines...) Expand 10 before | Expand all | Expand 10 after
1655 public: 1658 public:
1656 explicit EnsureSpace(Assembler* assembler) { 1659 explicit EnsureSpace(Assembler* assembler) {
1657 assembler->CheckBuffer(); 1660 assembler->CheckBuffer();
1658 } 1661 }
1659 }; 1662 };
1660 1663
1661 1664
1662 } } // namespace v8::internal 1665 } } // namespace v8::internal
1663 1666
1664 #endif // V8_ARM_ASSEMBLER_ARM_H_ 1667 #endif // V8_ARM_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/assembler-arm-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698