Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: src/ia32/assembler-ia32.h

Issue 1332283002: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Make serializer aware of new methods Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 471 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 // The relocation writer's position must be kGap bytes above the end of 482 // The relocation writer's position must be kGap bytes above the end of
483 // the generated instructions. This leaves enough space for the 483 // the generated instructions. This leaves enough space for the
484 // longest possible ia32 instruction, 15 bytes, and the longest possible 484 // longest possible ia32 instruction, 15 bytes, and the longest possible
485 // relocation information encoding, RelocInfoWriter::kMaxLength == 16. 485 // relocation information encoding, RelocInfoWriter::kMaxLength == 16.
486 // (There is a 15 byte limit on ia32 instruction length that rules out some 486 // (There is a 15 byte limit on ia32 instruction length that rules out some
487 // otherwise valid instructions.) 487 // otherwise valid instructions.)
488 // This allows for a single, fast space check per instruction. 488 // This allows for a single, fast space check per instruction.
489 static const int kGap = 32; 489 static const int kGap = 32;
490 490
491 public: 491 public:
492 using AssemblerBase::FlushICache;
493 using AssemblerBase::FlushICacheWithoutIsolate;
494
492 // Create an assembler. Instructions and relocation information are emitted 495 // Create an assembler. Instructions and relocation information are emitted
493 // into a buffer, with the instructions starting from the beginning and the 496 // into a buffer, with the instructions starting from the beginning and the
494 // relocation information starting from the end of the buffer. See CodeDesc 497 // relocation information starting from the end of the buffer. See CodeDesc
495 // for a detailed comment on the layout (globals.h). 498 // for a detailed comment on the layout (globals.h).
496 // 499 //
497 // If the provided buffer is NULL, the assembler allocates and grows its own 500 // If the provided buffer is NULL, the assembler allocates and grows its own
498 // buffer, and buffer_size determines the initial buffer size. The buffer is 501 // buffer, and buffer_size determines the initial buffer size. The buffer is
499 // owned by the assembler and deallocated upon destruction of the assembler. 502 // owned by the assembler and deallocated upon destruction of the assembler.
500 // 503 //
501 // If the provided buffer is not NULL, the assembler uses the provided buffer 504 // If the provided buffer is not NULL, the assembler uses the provided buffer
(...skipping 1089 matching lines...) Expand 10 before | Expand all | Expand 10 after
1591 private: 1594 private:
1592 Assembler* assembler_; 1595 Assembler* assembler_;
1593 #ifdef DEBUG 1596 #ifdef DEBUG
1594 int space_before_; 1597 int space_before_;
1595 #endif 1598 #endif
1596 }; 1599 };
1597 1600
1598 } } // namespace v8::internal 1601 } } // namespace v8::internal
1599 1602
1600 #endif // V8_IA32_ASSEMBLER_IA32_H_ 1603 #endif // V8_IA32_ASSEMBLER_IA32_H_
OLDNEW
« src/assembler.cc ('K') | « src/deoptimizer.cc ('k') | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698