Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1332273003: Change the print preview UI to use the material design style buttons for zoom (Closed)

Created:
5 years, 3 months ago by raymes
Modified:
5 years, 3 months ago
Reviewers:
tsergeant, Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the print preview UI to use the material design style buttons for zoom This changes print preview to use the material buttons for zooming. It also reconciles the codepaths so that print preview uses the same codepath as the material design viewer which will allow us to remove a bunch of code once the material UI is switched on by default. BUG= Committed: https://crrev.com/afc5c4888e220c21cf3edebe8f615bb66e33c7b8 Cr-Commit-Position: refs/heads/master@{#349371}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -61 lines) Patch
M chrome/browser/resources/pdf/index-material.css View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/index-material.html View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 2 3 12 chunks +53 lines, -32 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 1 1 chunk +20 lines, -7 lines 0 comments Download
M chrome/browser/resources/pdf/toolbar_manager.js View 1 2 3 6 chunks +16 lines, -7 lines 0 comments Download
M pdf/out_of_process_instance.cc View 3 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 27 (11 generated)
raymes
5 years, 3 months ago (2015-09-15 05:19:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332273003/1
5 years, 3 months ago (2015-09-15 05:20:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 06:05:19 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332273003/20001
5 years, 3 months ago (2015-09-15 07:20:57 UTC) #8
raymes
Updated to use fetch. PTAL :)
5 years, 3 months ago (2015-09-15 07:21:35 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 08:18:43 UTC) #11
Sam McNally
lgtm https://codereview.chromium.org/1332273003/diff/20001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1332273003/diff/20001/chrome/browser/resources/pdf/pdf.js#newcode141 chrome/browser/resources/pdf/pdf.js:141: this.topToolbarHeight = this.topToolbarHeight_
5 years, 3 months ago (2015-09-16 06:29:39 UTC) #12
raymes
https://codereview.chromium.org/1332273003/diff/20001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1332273003/diff/20001/chrome/browser/resources/pdf/pdf.js#newcode141 chrome/browser/resources/pdf/pdf.js:141: this.topToolbarHeight = Hmm I'm not sure why I changed ...
5 years, 3 months ago (2015-09-16 06:57:17 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332273003/40001
5 years, 3 months ago (2015-09-17 02:33:01 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/70390) ios_rel_device_ninja on ...
5 years, 3 months ago (2015-09-17 02:34:56 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332273003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332273003/60001
5 years, 3 months ago (2015-09-17 02:41:12 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 03:20:15 UTC) #21
tsergeant
Generally looks good to me, but deferring to Sam
5 years, 3 months ago (2015-09-17 06:45:33 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332273003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332273003/60001
5 years, 3 months ago (2015-09-17 06:46:09 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-17 07:15:56 UTC) #26
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 07:16:56 UTC) #27
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/afc5c4888e220c21cf3edebe8f615bb66e33c7b8
Cr-Commit-Position: refs/heads/master@{#349371}

Powered by Google App Engine
This is Rietveld 408576698