Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(181)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/paint/invalidation/text-decoration-invalidation-expected.html
Issue
1332233002
:
Invalidate whitespace text on text color changes (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: TextOrColorChanged -> TextDecorationOrColorChanged
Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/TestExpectations
LayoutTests/fast/repaint/inline-outline-repaint-2-expected.txt
LayoutTests/paint/invalidation/non-text-link-invalidation-optimization.html
LayoutTests/paint/invalidation/non-text-link-invalidation-optimization-expected.txt
LayoutTests/paint/invalidation/spv2/inline-outline-repaint-2.html
LayoutTests/paint/invalidation/text-decoration-invalidation.html
LayoutTests/paint/invalidation/text-decoration-invalidation-expected.html
Source/core/layout/LayoutObject.cpp
Source/core/style/ComputedStyle.cpp
Source/core/style/StyleDifference.h
View unified diff
|
Download patch
« no previous file with comments
|
« LayoutTests/paint/invalidation/text-decoration-invalidation.html
('k') |
Source/core/layout/LayoutObject.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<style>
3
div {
4
display: block;
5
width: 400px;
6
height: 100px;
7
color: blue;
8
}
9
#underlineHover {
10
text-decoration: underline;
11
}
12
</style>
13
<div id="underlineHover">
14
<span>When</span> <span>hovered, </span><span>there</span> <span>should</span> <span> be </span> <span>no</span> <span>gaps</span> <span>in</span> <span>the< /span> <span>underline.</span>
15
</div>
16
17
<div id="underlineNoHover">
18
<span>When</span> <span>not hovered, </span><span>there</span> <span>should</spa n> <span> be </span> <span>no</span> <span>underlines.</span>
19
</div>
OLD
NEW
« no previous file with comments
|
« LayoutTests/paint/invalidation/text-decoration-invalidation.html
('k') |
Source/core/layout/LayoutObject.cpp »
('j') |
no next file with comments »
Issue 1332233002: Invalidate whitespace text on text color changes (Closed)
Created 5 years, 3 months ago by pdr.
Modified 5 years, 3 months ago
Reviewers: chrishtr
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 2
This is Rietveld
408576698
Chromium Code Reviews
Issue 1332233002:
Invalidate whitespace text on text color changes (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master