Issue 133223002: Revert 243816 "[Files.app] Change sort timing during metadata fetch"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133223002: Revert 243816 "[Files.app] Change sort timing during metadata fetch" (Closed)

Created:
6 years, 11 months ago by yoshiki

Modified:
6 years, 11 months ago

Reviewers:
yoshiki

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 243816 "[Files.app] Change sort timing during metadata fetch" > [Files.app] Change sort timing during metadata fetch > > Previously, sort was not started until all the metadata is fetched. When fetching took a time, the user saw unsorted list for a while. With this patch, sort is happened just after every updates. User can see sorted list every time. > > BUG=327479 > TEST=manually tested > > Review URL: https://codereview.chromium.org/113293007 TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244082

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -47 lines)			Patch
M	trunk/src/chrome/browser/resources/file_manager/foreground/js/directory_contents.js	View	6 chunks	+17 lines, -19 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/file_manager/foreground/js/file_manager.js	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js	View	5 chunks	+4 lines, -28 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r244082.

Expand Messages | Collapse Messages