Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 13322003: Update the remaining references to sys_string_conversions.h to its new location. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, dcheng, Albert Bodenhamer, kinuko+watch, Ilya Sherman, haitaol1, dcaiafa+watch_chromium.org, benquan, dbeam+watch-autofill_chromium.org, tzik+watch_chromium.org, darin-cc_chromium.org, Raghu Simha, tim (not reviewing), wez+watch_chromium.org, yoshiki+watch_chromium.org, sanjeevr, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, Raman Kakilate, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, akalin, sail+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, Dane Wallinga, dyu1, Paweł Hajdan Jr., estade+watch_chromium.org, alexeypa+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M components/autofill/browser/personal_data_manager_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M crypto/cssm_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_mf_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_settings_initializer_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/clipboard_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/continue_window_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/disconnect_window_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/policy_hack/policy_watcher_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M rlz/mac/lib/machine_id_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/mac/lib/rlz_value_store_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/process_policy_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/tests/common/controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/get_session_name_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/get_session_name_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/popup_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/base/file_path_string_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/blob/blob_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_mount_point_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_util.cc View 1 chunk +1 line, -1 line 1 comment Download
M webkit/fileapi/local_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/obfuscated_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/ftp_directory_listing_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/simple_webmimeregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webmenurunner_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_lib_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_lib_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/user_agent/user_agent_util_ios.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tfarina
TBRing OWNERS... Brett, fyi.
7 years, 8 months ago (2013-03-29 17:45:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13322003/1
7 years, 8 months ago (2013-03-29 17:46:13 UTC) #2
Ryan Sleevi
crypto/ LGTM
7 years, 8 months ago (2013-03-29 17:46:30 UTC) #3
Ami GONE FROM CHROMIUM
media/ LGTM
7 years, 8 months ago (2013-03-29 17:47:50 UTC) #4
keybuk
device/ lgtm
7 years, 8 months ago (2013-03-29 18:11:33 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-03-29 18:25:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13322003/1
7 years, 8 months ago (2013-03-29 18:28:01 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-03-29 18:43:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13322003/1
7 years, 8 months ago (2013-03-29 18:58:20 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-03-29 19:11:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13322003/1
7 years, 8 months ago (2013-03-29 19:12:42 UTC) #11
Lei Zhang
printing/ lgtm
7 years, 8 months ago (2013-03-29 19:21:37 UTC) #12
tony
webkit lgtm https://codereview.chromium.org/13322003/diff/1/webkit/fileapi/file_system_util.cc File webkit/fileapi/file_system_util.cc (right): https://codereview.chromium.org/13322003/diff/1/webkit/fileapi/file_system_util.cc#newcode12 webkit/fileapi/file_system_util.cc:12: #include "base/strings/sys_string_conversions.h" Nit: I think strings/sys_string_conversions.h should ...
7 years, 8 months ago (2013-03-29 19:57:43 UTC) #13
commit-bot: I haz the power
7 years, 8 months ago (2013-03-30 00:27:02 UTC) #14
Message was sent while issue was closed.
Change committed as 191479

Powered by Google App Engine
This is Rietveld 408576698