Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1332163005: nacl: Be more consistent about setting nacl_untrusted_build on targets that use untrusted.gypi (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
bradnelson, raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nacl: Be more consistent about setting nacl_untrusted_build on targets that use untrusted.gypi The motivation is that I want to add a certain include_dir to all targets (to use libc++ on OS X), _except_ for NaCl targets, since these have their own bundled C++ standard library already. Checking for nacl_untrusted_build almost works, but a handful nacl targets didn't set that yet. Fix this. No intended behavior change. BUG=400091 Committed: https://crrev.com/cdde1a7e0f809dd3b368e5f8c48292bafdba9808 Cr-Commit-Position: refs/heads/master@{#348815}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ppapi/ppapi_nacl.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M ppapi/ppapi_nacl_test_common.gypi View 1 chunk +1 line, -0 lines 2 comments Download
M third_party/libjingle/libjingle_nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/modp_b64/modp_b64_nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Nico
5 years, 3 months ago (2015-09-15 01:00:45 UTC) #2
Nico
https://codereview.chromium.org/1332163005/diff/1/ppapi/ppapi_nacl_test_common.gypi File ppapi/ppapi_nacl_test_common.gypi (right): https://codereview.chromium.org/1332163005/diff/1/ppapi/ppapi_nacl_test_common.gypi#newcode17 ppapi/ppapi_nacl_test_common.gypi:17: 'nacl_untrusted_build': 1, (seems like every target including this gypi ...
5 years, 3 months ago (2015-09-15 01:01:20 UTC) #3
bradnelson
lgtm https://codereview.chromium.org/1332163005/diff/1/ppapi/ppapi_nacl_test_common.gypi File ppapi/ppapi_nacl_test_common.gypi (right): https://codereview.chromium.org/1332163005/diff/1/ppapi/ppapi_nacl_test_common.gypi#newcode17 ppapi/ppapi_nacl_test_common.gypi:17: 'nacl_untrusted_build': 1, On 2015/09/15 01:01:20, Nico wrote: > ...
5 years, 3 months ago (2015-09-15 01:25:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332163005/1
5 years, 3 months ago (2015-09-15 01:28:22 UTC) #6
Nico
On 2015/09/15 01:25:16, bradnelson wrote: > lgtm > > https://codereview.chromium.org/1332163005/diff/1/ppapi/ppapi_nacl_test_common.gypi > File ppapi/ppapi_nacl_test_common.gypi (right): > ...
5 years, 3 months ago (2015-09-15 01:28:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99709)
5 years, 3 months ago (2015-09-15 01:39:41 UTC) #9
Nico
raymes: ppapi/OWNERS stamp, please
5 years, 3 months ago (2015-09-15 01:49:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332163005/1
5 years, 3 months ago (2015-09-15 01:50:12 UTC) #13
raymes
rubberstamp lgtm
5 years, 3 months ago (2015-09-15 01:52:55 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 01:57:39 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cdde1a7e0f809dd3b368e5f8c48292bafdba9808 Cr-Commit-Position: refs/heads/master@{#348815}
5 years, 3 months ago (2015-09-15 01:58:12 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:41:24 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdde1a7e0f809dd3b368e5f8c48292bafdba9808
Cr-Commit-Position: refs/heads/master@{#348815}

Powered by Google App Engine
This is Rietveld 408576698