|
|
Chromium Code Reviews|
Created:
5 years, 3 months ago by Dirk Pranke Modified:
5 years, 3 months ago Reviewers:
brettw CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip Linux debug bots to GN.
R=brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng
Committed: https://crrev.com/cdb8d6dbe67c33d53c43dc6091d8ee4655ce7d3c
Cr-Commit-Position: refs/heads/master@{#348811}
Patch Set 1 #Patch Set 2 : merge #Messages
Total messages: 16 (7 generated)
lgtm
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332133002/1
The CQ bit was unchecked by dpranke@chromium.org
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332133002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for tools/mb/mb_config.pyl:
While running git apply --index -3 -p1;
error: patch failed: tools/mb/mb_config.pyl:51
Falling back to three-way merge...
Applied patch to 'tools/mb/mb_config.pyl' with conflicts.
U tools/mb/mb_config.pyl
Patch: tools/mb/mb_config.pyl
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index
d5a4a6ade04f23cec2b07a95bd7ba1bcbc06f8cb..679274948f8f33584ba4bb03e2c2f062a4a0fdfc
100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -51,10 +51,10 @@
'swarming_msan_gyp_release_trybot': ['swarming', 'chromeos', 'msan', 'gyp',
'release_trybot'],
'swarming_deterministic_gyp_release_bot': ['swarming', 'deterministic',
'gyp', 'release_bot'],
'swarming_gpu_tests_gn_release_trybot': ['swarming', 'gpu_tests', 'gn',
'release_trybot'],
+ 'swarming_gn_debug_bot': ['swarming', 'gn', 'debug_bot'],
+ 'swarming_gn_debug_trybot': ['swarming', 'gn', 'debug_bot'],
'swarming_gn_release_bot': ['swarming', 'gn', 'release_bot'],
- 'swarming_gyp_debug_bot': ['swarming', 'gyp', 'debug_bot'],
'swarming_gyp_debug_bot_no_symbols_x86': ['swarming', 'gyp', 'debug_bot',
'no_symbols', 'x86'],
- 'swarming_gyp_debug_trybot': ['swarming', 'gyp', 'debug_trybot'],
'swarming_gyp_debug_trybot_x86': ['swarming', 'gyp', 'debug_trybot',
'x86'],
'swarming_gyp_release_bot': ['swarming', 'gyp', 'release_bot'],
'swarming_gyp_release_trybot': ['swarming', 'gyp', 'release_trybot'],
@@ -299,8 +299,8 @@
'Linux Tests': 'swarming_gn_release_bot',
'Linux Builder (dbg)(32)': 'swarming_gyp_debug_bot_no_symbols_x86',
'Linux Tests (dbg)(1)(32)': 'swarming_gyp_debug_bot_no_symbols_x86',
- 'Linux Builder (dbg)': 'swarming_gyp_debug_bot',
- 'Linux Tests (dbg)(1)': 'swarming_gyp_debug_bot',
+ 'Linux Builder (dbg)': 'swarming_gn_debug_bot',
+ 'Linux Tests (dbg)(1)': 'swarming_gn_debug_bot',
'Linux GN': 'gn_release_bot',
'Linux GN Clobber': 'gn_release_bot',
'Linux GN (dbg)': 'gn_debug_bot',
@@ -380,8 +380,8 @@
'linux_chromium_gn_rel': 'gn_release_trybot',
'linux_chromium_gn_chromeos_rel': 'chromeos_gn_release_trybot',
'android_chromium_gn_compile_rel': 'android_gn_release_trybot',
- 'linux_chromium_compile_dbg_ng': 'swarming_gyp_debug_trybot',
- 'linux_chromium_dbg_ng': 'swarming_gyp_debug_trybot',
+ 'linux_chromium_compile_dbg_ng': 'swarming_gn_debug_trybot',
+ 'linux_chromium_dbg_ng': 'swarming_gn_debug_trybot',
'linux_chromium_trusty_dbg': 'gyp_debug_bot',
'linux_chromium_trusty32_dbg': 'gyp_debug_bot_x86',
'linux_chromium_gn_dbg': 'gn_debug_bot',
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/1332133002/#ps20001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332133002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cdb8d6dbe67c33d53c43dc6091d8ee4655ce7d3c Cr-Commit-Position: refs/heads/master@{#348811}
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cdb8d6dbe67c33d53c43dc6091d8ee4655ce7d3c Cr-Commit-Position: refs/heads/master@{#348811} |
