Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1332083002: Task Manager Should remember the most recently enabled columns. (Closed)

Created:
5 years, 3 months ago by afakhry
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Task Manager Should remember the most recently enabled columns. This CL: 1- Makes adding and removing columns to the task manager a lot easier and cleaner. 2- Stores/retrieves the columns visibility to/from the local state prefs. 3- Stores/retrieves the sorted column and the sort order. TBR=thestig@chromium.org BUG=452521 TEST=browser_tests --gtest_filter=NewTaskManagerViewTest.* Committed: https://crrev.com/4e16add803fbb0ed18413496d3fb4424fa4957c6 Cr-Commit-Position: refs/heads/master@{#346524} Review URL: https://codereview.chromium.org/1320563002 Cr-Commit-Position: refs/heads/master@{#346734} (cherry picked from commit 4780b87d1c25f68c39abc623199f3e71a477d32d) Committed: https://chromium.googlesource.com/chromium/src/+/66147f68983ac39e559afc9b3776d3da8454c7d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -144 lines) Patch
M chrome/browser/task_management/providers/child_process_task_provider.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.h View 3 chunks +57 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.cc View 8 chunks +227 lines, -139 lines 0 comments Download
A chrome/browser/ui/views/new_task_manager_view_browsertest.cc View 1 chunk +144 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
afakhry
Committed patchset #1 (id:1) manually as 66147f68983ac39e559afc9b3776d3da8454c7d5 (presubmit successful).
5 years, 3 months ago (2015-09-10 21:14:00 UTC) #1
Lei Zhang
5 years, 3 months ago (2015-09-10 21:16:45 UTC) #2
Message was sent while issue was closed.
rs lgtm

Maybe prepend "Merge to M46: " so it's more obvious that this is a merge next
time.

Powered by Google App Engine
This is Rietveld 408576698