chrome/android/java/res/layout/permission_group_infobar_item.xml - Issue 1332063003: permissions: implement coalesced permissions on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/permission_group_infobar_item.xml

Issue 1332063003: permissions: implement coalesced permissions on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@request-multiple

Patch Set: Bring CL up to scratch with mocks Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/permission_group_infobar.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2015 The Chromium Authors. All rights reserved.

	4

	5 Use of this source code is governed by a BSD-style license that can be

	6 found in the LICENSE file.

	7 -->

	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
	gone 2015/09/18 21:02:42 After talking with Rebecca about this, we'll want After talking with Rebecca about this, we'll want to generalize this, probably through the InfoBarLayout. There's a checkbox in the (currently implemented) translate infobar that UX is requesting to become a toggle like the permissions stuff, instead, with the same spacings and such. Lalit Maganti 2015/09/21 11:20:08 Acknowledged. Show quoted text On 2015/09/18 21:02:42, dfalcantara wrote: > After talking with Rebecca about this, we'll want to generalize this, probably > through the InfoBarLayout. There's a checkbox in the (currently implemented) > translate infobar that UX is requesting to become a toggle like the permissions > stuff, instead, with the same spacings and such. Acknowledged.
	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:orientation="horizontal"

	12 android:padding="8dp" >

	13

	14 <ImageView

	15 android:id="@+id/permission_group_infobar_item_icon"

	16 android:contentDescription="@null"

	17 android:layout_width="28dp"

	18 android:layout_height="28dp"

	19 android:layout_gravity="center_vertical"

	20 android:layout_marginEnd="8dp" />

	21

	22 <TextView

	23 android:id="@+id/permission_group_infobar_item_text"

	24 android:text="@string/password_entry_editor_title"

	25 android:textColor="@color/default_text_color"

	26 android:textSize="14sp"

	27 android:layout_width="0dp"

	28 android:layout_height="wrap_content"

	29 android:layout_gravity="center_vertical"

	30 android:layout_weight="1" />

	31

	32 <Switch

	33 android:id="@+id/permission_group_infobar_item_switch"

	34 android:checked="true"

	35 android:layout_marginStart="16dp"

	36 android:layout_width="wrap_content"

	37 android:layout_height="wrap_content"

	38 android:layout_gravity="center_vertical" />

	39 </LinearLayout>

OLD	NEW