Index: tests/CodexTest.cpp |
diff --git a/tests/CodexTest.cpp b/tests/CodexTest.cpp |
index f1c5bbaa128e1c989bf06af39f27f7a22e211864..c03265f4566f0fc511fb776414f3dfbe4dc3c3f2 100644 |
--- a/tests/CodexTest.cpp |
+++ b/tests/CodexTest.cpp |
@@ -159,8 +159,8 @@ static void check(skiatest::Reporter* r, |
REPORTER_ASSERT(r, startResult == SkCodec::kSuccess); |
for (int y = 0; y < info.height(); y++) { |
- result = codec->getScanlines(bm.getAddr(0, y), 1, 0); |
- REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
+ const uint32_t lines = codec->getScanlines(bm.getAddr(0, y), 1, 0); |
+ REPORTER_ASSERT(r, 1 == lines); |
} |
// verify that scanline decoding gives the same result. |
if (SkCodec::kTopDown_SkScanlineOrder == codec->getScanlineOrder()) { |
@@ -321,12 +321,12 @@ DEF_TEST(Codec_stripes, r) { |
// Odd stripes |
for (int i = 1; i < numStripes; i += 2) { |
// Skip the even stripes |
- result = codec->skipScanlines(stripeHeight); |
- REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
+ bool skipResult = codec->skipScanlines(stripeHeight); |
+ REPORTER_ASSERT(r, skipResult); |
- result = codec->getScanlines(bm.getAddr(0, i * stripeHeight), stripeHeight, |
+ int linesDecoded = codec->getScanlines(bm.getAddr(0, i * stripeHeight), stripeHeight, |
bm.rowBytes()); |
- REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
+ REPORTER_ASSERT(r, linesDecoded == stripeHeight); |
} |
// Even stripes |
@@ -334,14 +334,14 @@ DEF_TEST(Codec_stripes, r) { |
REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
for (int i = 0; i < numStripes; i += 2) { |
- result = codec->getScanlines(bm.getAddr(0, i * stripeHeight), stripeHeight, |
+ int linesDecoded = codec->getScanlines(bm.getAddr(0, i * stripeHeight), stripeHeight, |
bm.rowBytes()); |
- REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
+ REPORTER_ASSERT(r, linesDecoded == stripeHeight); |
// Skip the odd stripes |
if (i + 1 < numStripes) { |
- result = codec->skipScanlines(stripeHeight); |
- REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
+ bool skipResult = codec->skipScanlines(stripeHeight); |
+ REPORTER_ASSERT(r, skipResult); |
} |
} |
@@ -350,12 +350,12 @@ DEF_TEST(Codec_stripes, r) { |
result = codec->startScanlineDecode(info); |
REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
- result = codec->skipScanlines(height - remainingLines); |
- REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
+ bool skipResult = codec->skipScanlines(height - remainingLines); |
+ REPORTER_ASSERT(r, skipResult); |
- result = codec->getScanlines(bm.getAddr(0, height - remainingLines), |
+ int linesDecoded = codec->getScanlines(bm.getAddr(0, height - remainingLines), |
remainingLines, bm.rowBytes()); |
- REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
+ REPORTER_ASSERT(r, linesDecoded == height - remainingLines); |
} |
compare_to_good_digest(r, digest, bm); |