src/codec/SkCodec_libpng.h - Issue 1332053002: Fill incomplete images in SkCodec parent class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec_libpng.h

Issue 1332053002: Fill incomplete images in SkCodec parent class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Response to comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec_libpng.h

diff --git a/src/codec/SkCodec_libpng.h b/src/codec/SkCodec_libpng.h

index e8807499ea74419a7e81535a01c44af589f24466..ffa6d0c496c58fe66831447caa121f9761c348f4 100644

--- a/src/codec/SkCodec_libpng.h

+++ b/src/codec/SkCodec_libpng.h

@@ -32,11 +32,12 @@ public:

virtual ~SkPngCodec();

protected:

- Result onGetPixels(const SkImageInfo&, void*, size_t, const Options&, SkPMColor*, int*)

+ Result onGetPixels(const SkImageInfo&, void*, size_t, const Options&, SkPMColor*, int*, int*)

override;

SkEncodedFormat onGetEncodedFormat() const override { return kPNG_SkEncodedFormat; }

bool onRewind() override;

bool onReallyHasAlpha() const override { return fReallyHasAlpha; }

+ uint32_t onGetFillValue(const SkImageInfo& dstInfo) const override;

private:

png_structp fPng_ptr;