Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: src/codec/SkCodec_libgif.h

Issue 1332053002: Fill incomplete images in SkCodec parent class (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Response to comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/codec/SkCodec_libgif.h
diff --git a/src/codec/SkCodec_libgif.h b/src/codec/SkCodec_libgif.h
index 88455368512efb47766b9c06aeb16a18a9eeb99a..42571ad4943a9d05ab03287dd8664d6f9da424b7 100644
--- a/src/codec/SkCodec_libgif.h
+++ b/src/codec/SkCodec_libgif.h
@@ -63,7 +63,7 @@ protected:
* Performs the full gif decode
*/
Result onGetPixels(const SkImageInfo&, void*, size_t, const Options&,
- SkPMColor*, int32_t*) override;
+ SkPMColor*, int*, int*) override;
SkEncodedFormat onGetEncodedFormat() const override {
return kGIF_SkEncodedFormat;
@@ -71,6 +71,8 @@ protected:
bool onRewind() override;
+ uint32_t onGetFillValue(const SkImageInfo& dstInfo) const override;
+
private:
/*
@@ -129,10 +131,9 @@ private:
ZeroInitialized zeroInit);
/*
- * @return kSuccess if the read is successful and kIncompleteInput if the
- * read fails.
+ * @return true if the read is successful and false if the read fails.
*/
- SkCodec::Result readRow();
+ bool readRow();
/*
* This function cleans up the gif object after the decode completes

Powered by Google App Engine
This is Rietveld 408576698