Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/codec/SkWebpCodec.h

Issue 1332053002: Fill incomplete images in SkCodec parent class (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Forgot to add SkSampler.cpp Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkWebpCodec_DEFINED 8 #ifndef SkWebpCodec_DEFINED
9 #define SkWebpCodec_DEFINED 9 #define SkWebpCodec_DEFINED
10 10
11 #include "SkCodec.h" 11 #include "SkCodec.h"
12 #include "SkEncodedFormat.h" 12 #include "SkEncodedFormat.h"
13 #include "SkImageInfo.h" 13 #include "SkImageInfo.h"
14 #include "SkTypes.h" 14 #include "SkTypes.h"
15 15
16 class SkStream; 16 class SkStream;
17 17
18 class SkWebpCodec final : public SkCodec { 18 class SkWebpCodec final : public SkCodec {
19 public: 19 public:
20 // Assumes IsWebp was called and returned true. 20 // Assumes IsWebp was called and returned true.
21 static SkCodec* NewFromStream(SkStream*); 21 static SkCodec* NewFromStream(SkStream*);
22 static bool IsWebp(SkStream*); 22 static bool IsWebp(SkStream*);
23 protected: 23 protected:
24 Result onGetPixels(const SkImageInfo&, void*, size_t, const Options&, SkPMCo lor*, int*) 24 Result onGetPixels(const SkImageInfo&, void*, size_t, const Options&, SkPMCo lor*, int*, int*)
25 override; 25 override;
26 SkEncodedFormat onGetEncodedFormat() const override { return kWEBP_SkEncoded Format; } 26 SkEncodedFormat onGetEncodedFormat() const override { return kWEBP_SkEncoded Format; }
27 27
28 bool onReallyHasAlpha() const override { 28 bool onReallyHasAlpha() const override {
29 return this->getInfo().alphaType() != kOpaque_SkAlphaType; 29 return this->getInfo().alphaType() != kOpaque_SkAlphaType;
30 } 30 }
31 31
32 SkISize onGetScaledDimensions(float desiredScale) const override; 32 SkISize onGetScaledDimensions(float desiredScale) const override;
33 33
34 bool onDimensionsSupported(const SkISize&) override; 34 bool onDimensionsSupported(const SkISize&) override;
35 35
36 bool onGetValidSubset(SkIRect* /* desiredSubset */) const override; 36 bool onGetValidSubset(SkIRect* /* desiredSubset */) const override;
37
38 SkSampler* getSampler() override;
37 private: 39 private:
38 SkWebpCodec(const SkImageInfo&, SkStream*); 40 SkWebpCodec(const SkImageInfo&, SkStream*);
39 41
42 SkAutoTDelete<SkSampler> fSampler;
scroggo 2015/10/07 16:04:24 I don't understand why webp ever needs a sampler.
msarett 2015/10/07 17:40:41 Removed in Patch Set 11.
43 // Dummy webp sampler needs to know the destination width.
44 int fDstWidth;
45 friend class SkWebpSampler;
46
40 typedef SkCodec INHERITED; 47 typedef SkCodec INHERITED;
41 }; 48 };
42 #endif // SkWebpCodec_DEFINED 49 #endif // SkWebpCodec_DEFINED
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698