Source/core/svg/SVGFontFaceElement.cpp - Issue 133203003: Generate toSVGFooElement() for SVGFELight|AnimateMotion|FontFaceSrc|TextPositioningElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGFontFaceElement.cpp

Issue 133203003: Generate toSVGFooElement() for SVGFELight|AnimateMotion|FontFaceSrc|TextPositioningElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/svg/SVGFELightElement.cpp ('K') | « Source/core/svg/SVGFELightElement.cpp ('k') | Source/core/svg/SVGFontFaceSrcElement.h » ('j') | Source/core/svg/SVGTextPositioningElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/SVGFontFaceElement.cpp

diff --git a/Source/core/svg/SVGFontFaceElement.cpp b/Source/core/svg/SVGFontFaceElement.cpp

index 73402cb64b750f9febc1894f39c571360b7d9cfb..a8955438b13b5291bdc71a267be8e5115e2f9d7e 100644

--- a/Source/core/svg/SVGFontFaceElement.cpp

+++ b/Source/core/svg/SVGFontFaceElement.cpp

@@ -278,7 +278,7 @@ void SVGFontFaceElement::rebuildFontFace()

for (Node* child = firstChild(); child && !srcElement; child = child->nextSibling()) {

if (child->hasTagName(font_face_srcTag))

- srcElement = static_cast<SVGFontFaceSrcElement*>(child);

+ srcElement = toSVGFontFaceSrcElement(child);

Stephen Chennney 2014/01/10 12:32:53 Ditto.

gyuyoung-inactive 2014/01/12 04:37:31 Done.

}

bool describesParentFont = parentNode()->hasTagName(SVGNames::fontTag);