Generate toSVGFooElement() for SVGFELight|AnimateMotion|FontFaceSrc|TextPositioningElement

Source/core/svg/SVGFELightElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
  * Copyright (C) 2005 Oliver Hunt <oliver@nerget.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 52 matching lines @@
 {
     registerAnimatedPropertiesForSVGFELightElement();
 }
 
 SVGFELightElement* SVGFELightElement::findLightElement(const SVGElement* svgElement)
 {
     for (Node* node = svgElement->firstChild(); node; node = node->nextSibling()) {
         if (node->hasTagName(SVGNames::feDistantLightTag)
             || node->hasTagName(SVGNames::fePointLightTag)
             || node->hasTagName(SVGNames::feSpotLightTag)) {
-            return static_cast<SVGFELightElement*>(node);
+            return toSVGFELightElement(node);

[Stephen Chennney, 2014/01/10 12:32:53]

You are doing the hasTagName queries twice. I have some issues in this case with
using toBlah at all, as the calling code ensures safety and no other code calls
it. Regardless, this should be re-written to avoid all of the hasTagName queries
here.

[gyuyoung-inactive, 2014/01/12 04:37:31]

DEFINE_NODE_TYPE_CASTS macro only calls "hasTagName()" on debug build, not
release mode.

Frankly, it looks we don't need to call "hasTagName()" here. However,
toSVGFELightElement() needs to call it when it is used by other places which
don't check tag name in order to guarantee safer type cast. That's why
DEFINE_NODE_TYPE_CASTS checks tag name or child element. If I don't understand
what is your question correctly, please let me know.

#define DEFINE_TYPE_CASTS(thisType, argumentType, argumentName,
pointerPredicate, referencePredicate) \
inline thisType* to##thisType(argumentType* argumentName) \
{ \
    ASSERT_WITH_SECURITY_IMPLICATION(!argumentName || (pointerPredicate)); \
    return static_cast<thisType*>(argumentName); \
} \

BTW, it would be good to use isSVGFELightElement() instead of using
"hasTagName()" conditions.

         }
     }
     return 0;
 }
 
 PassRefPtr<LightSource> SVGFELightElement::findLightSource(const SVGElement* svgElement)
 {
     SVGFELightElement* lightNode = findLightElement(svgElement);
     if (!lightNode)
         return 0;
@@ skipping 124 matching lines @@
     if (!changedByParser) {
         if (ContainerNode* parent = parentNode()) {
             RenderObject* renderer = parent->renderer();
             if (renderer && renderer->isSVGResourceFilterPrimitive())
                 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);
         }
     }
 }
 
 }